Repository navigation
Support RSSI reporting for TWR and DL-TDoA measurements - #153
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements RSSI reporting configuration and support. It introduces a default RSSI reporting configuration, adds capability info for RSSI reporting, updates ranging measurements (both two-way and DL-TDoA) to include the RSSI value based on the session configuration, and adds corresponding integration tests to verify the behavior. There are no review comments, so I have no feedback to provide.
sameer
force-pushed
the
rssi-reporting
branch
from
October 28, 2026 22:31
f5fa3b6 to
b5f38f4
Compare
schilit
approved these changes
Oct 29, 2026
sameer
force-pushed
the
rssi-reporting
branch
2 times, most recently
from
October 29, 2026 01:35
6a9f335 to
dc78d16
Compare
Building on the DL-TDoA groundwork in PR #144, Pica still ignored the RSSI_REPORTING (0x13) session configuration and hardcoded 0xFF in ranging reports. Android decodes 0xFF as -127 dBm rather than RSSI_UNKNOWN, distorting client signal metrics. Advertise vendor capability SUPPORTED_RSSI_REPORTING (0xE6), emit 0x00 when disabled, and emit -50 dBm (100 in unsigned Q7.1 format) across Two-Way Ranging and DL-TDoA measurements when enabled. Closes #148
sameer
force-pushed
the
rssi-reporting
branch
from
October 29, 2026 01:35
dc78d16 to
535d9c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on the DL-TDoA groundwork in PR #144, Pica still ignored the RSSI_REPORTING (0x13) session configuration and hardcoded 0xFF in ranging reports. Android decodes 0xFF as -127 dBm rather than RSSI_UNKNOWN, distorting client signal metrics.
Advertise vendor capability SUPPORTED_RSSI_REPORTING (0xE6), emit 0x00 when disabled, and emit -50 dBm (100 in unsigned Q7.1 format) across Two-Way Ranging and DL-TDoA measurements when enabled.
Closes #148