Add section on impl existence reasoning - #2
Merged
Merged
Conversation
Manishearth
approved these changes
Aug 21, 2026
Manishearth
left a comment
Manishearth
left a comment
Collaborator
There was a problem hiding this comment.
I think this makes sense. Ought we also include some real traits that have this problem? E.g. mention DerefPure or something. Or are all such traits fixed already?
Contributor
Author
|
|
Collaborator
|
I guess if this pattern is Just Bad then we shouldn't be teaching the agent about real types that do it (that's more useful for it to be able to detect when such types are in play) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current unsafe code review skill misses one niche edge-case that quite a bit of rust code has inadvertently fallen into - both in library code e.g. bevy and in the standard library, so many times, on so many traits, even recently - twice. This is my attempt at a condensed form of the safety requirements needed to prevent such cases.
cc @obi1kenobi