Skip to content

Server: guarantee terminal shutdown after cleanup failures - #522

Closed
jzhvymetal wants to merge 1 commit into
google:masterfrom
opensagetv-vibe:sagetv-review/shutdown-hardening
Closed

jzhvymetal wants to merge 1 commit into
google:masterfrom
opensagetv-vibe:sagetv-review/shutdown-hardening

Conversation

@jzhvymetal

Copy link
Copy Markdown
Contributor

Summary

  • ensure terminal shutdown state is reached when linkage or plugin cleanup throws
  • keep the process-exit path from being skipped after listeners have already stopped

Validation

  • Complete Java suite passed in the Vibe extraction workspace.

Review state

Draft: requires explicit cleanup-failure injection across desktop, service, and embedded modes before it should merge.


This replaces OpenSageTV#7, which was opened against an intermediate fork instead of the canonical SageTV repository. The topic was replayed without patch changes onto the current canonical master.

@google-cla

google-cla Bot commented Sep 29, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jzhvymetal

Copy link
Copy Markdown
Contributor Author

Closing because the cleanup/linkage exception is currently theoretical. Normal startup and repeated shutdown tests pass, but no real or injected failure proves a server is left alive by this path, and the required desktop/service/embedded failure-injection matrix has not been completed. There is no demonstrated maintenance benefit yet.

@jzhvymetal jzhvymetal closed this Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant