Repository navigation
Server: guarantee terminal shutdown after cleanup failures - #522
Closed
jzhvymetal wants to merge 1 commit into
Closed
jzhvymetal wants to merge 1 commit into
jzhvymetal wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jzhvymetal
force-pushed
the
sagetv-review/shutdown-hardening
branch
from
September 29, 2026 12:25
7d2368a to
4de3ed6
Compare
Contributor
Author
|
Closing because the cleanup/linkage exception is currently theoretical. Normal startup and repeated shutdown tests pass, but no real or injected failure proves a server is left alive by this path, and the required desktop/service/embedded failure-injection matrix has not been completed. There is no demonstrated maintenance benefit yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Review state
Draft: requires explicit cleanup-failure injection across desktop, service, and embedded modes before it should merge.
This replaces OpenSageTV#7, which was opened against an intermediate fork instead of the canonical SageTV repository. The topic was replayed without patch changes onto the current canonical master.