Repository navigation
DVD: harden seek and menu-control transitions - #526
Draft
jzhvymetal wants to merge 1 commit into
Draft
jzhvymetal wants to merge 1 commit into
jzhvymetal wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jzhvymetal
force-pushed
the
sagetv-review/dvd-runtime-correctness
branch
from
September 29, 2026 12:26
e0bda13 to
6dedff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Review state
Draft: still requires the recorded physical-disc navigation and repeated-seek gate.
This replaces OpenSageTV#11, which was opened against an intermediate fork instead of the canonical SageTV repository. The topic was replayed without patch changes onto the current canonical master.
Maintenance triage (2026-09-29)
Disposition: draft; demonstrated DVD symptom exists, but this patch is too broad for maintenance review.
Observed user-visible failure: Skip Back near the beginning of a remotely played DVD produced a negative target, followed by FLUSH and stalled playback. A focused clamp and physical Fire TV sequence corrected that case. The current branch also changes direct-control job lifetime, lock behavior, authored stream selection, and transition state, which are not all necessary to fix the negative-seek symptom.
Before requesting review, split the minimal negative-seek correction from the other behavior, provide the exact before/after trace and authored fixture steps, and run repeated menu/seek/audio/subpicture gates on stock clients and the Java/Ogle path. The remaining transition work stays out of the merge queue until independently reproduced.