Repository navigation
Native: fix GCC 15 and 64-bit compatibility - #528
Draft
jzhvymetal wants to merge 1 commit into
Draft
jzhvymetal wants to merge 1 commit into
jzhvymetal wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jzhvymetal
force-pushed
the
sagetv-review/native-gcc15-64bit
branch
from
September 29, 2026 11:30
3562ba2 to
da9c75f
Compare
jzhvymetal
force-pushed
the
sagetv-review/native-gcc15-64bit
branch
from
September 29, 2026 12:27
da9c75f to
d0d9de2
Compare
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Review state
Draft while the broad native patch is split into independently reviewable maintenance changes. The applicable changes are intended for canonical SageTV so it can compile on current GCC/64-bit Linux environments; an upstream-supported platform matrix is still required before merge.
This replaces OpenSageTV#13, which was opened against an intermediate fork instead of the canonical SageTV repository. The topic was replayed without patch changes onto the current canonical master.
Maintenance triage (2026-09-29)
Disposition: active canonical modernization work; draft until split into reviewable patches.
Maintenance need: current GCC 15/64-bit compilation exposes obsolete prototypes, thread entry signatures, pointer/integer conversions, IPC layout assumptions, and bundled-library warnings/errors. These changes were required to advance the Vibe Ubuntu 26 build.
Available evidence: Java tests pass and native compilation advances to the separately known bundled-JPEG baseline. That is not a complete upstream platform matrix, and the patch touches multiple independent native subsystems.
Before review, split by native subsystem, retain the exact compiler diagnostics fixed by each change, and test the upstream-supported Linux architectures plus any affected Windows/macOS shared source. These smaller changes are intended for canonical SageTV; successful compilation alone does not prove a runtime behavior change.
Current-Ubuntu container dependency
This is the native-compiler prerequisite for the canonical current-Ubuntu container path. It is independent of #516 (launcher) and #519 (source-clean build), and it precedes the Ubuntu/ImageLoader work currently stacked in #529. After the Core changes pass individually, a separate
OpenSageTV/sagetv-dockersPR will own the non-root runtime image, packages, supervisor, health checks, and GPU device documentation. This draft should be split by native subsystem before merge review.