Skip to content

fix(stages,blueprints): remove unused dead variables from 3-security and postgresql - #207

Merged
aghassemlouei merged 5 commits into
mainfrom
fix/dead-variables-cleanup
Aug 31, 2026
Merged

fix(stages,blueprints): remove unused dead variables from 3-security and postgresql#207
aghassemlouei merged 5 commits into
mainfrom
fix/dead-variables-cleanup

Conversation

@aghassemlouei

Copy link
Copy Markdown
Collaborator

Description

This pull request cleans up declared variables that are never referenced by resources, data sources, or locals:

Fixes #112
Fixes #113

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: N/A

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in documentation/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP Moderate, FedRAMP High, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

  • Validated variable definitions across blueprints/il5/postgresql and fast/stages-aw/3-security.
  • Confirmed documentation variables tables match actual declared variables.

@aghassemlouei aghassemlouei added bug Something isn't working Priority - Low Minor polish, typo fixes, or technical debt; nice to have; pick up when time permits Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete labels Aug 28, 2026
@aghassemlouei

Copy link
Copy Markdown
Collaborator Author

@mgcarey-google would like someone else to take a peek at this. Adding additional reviewers and assignees.

@Calvin-Cheng1

Copy link
Copy Markdown
Collaborator

Agree with #112. Those are dead variables.

For #113 while these variables are unused in security.tf, they are intended to be available and consumable in case there are modules/resources in stage 3 that require any previous outputs from 0-bootstrap, 1-resman, or 2-networking. I would prefer to keep them

@aghassemlouei
aghassemlouei enabled auto-merge (squash) August 28, 2026 20:52

@Calvin-Cheng1 Calvin-Cheng1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some changes

@mgcarey-google mgcarey-google left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aghassemlouei
aghassemlouei merged commit 5949fa7 into main Aug 31, 2026
15 checks passed
@aghassemlouei
aghassemlouei deleted the fix/dead-variables-cleanup branch August 31, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - Low Minor polish, typo fixes, or technical debt; nice to have; pick up when time permits

Projects

None yet

4 participants