Repository navigation
Remove LegacyPrecision and absl-only tests from tsl/platform/numbers_test.cc. - #3667
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1003804305
branch
from
October 21, 2026 20:18
13dd47b to
344b266
Compare
…rs_test.cc`. The `safe_strto*` tests call `absl::SimpleAtoi`/`SimpleAtof`/`SimpleAtod` directly, and the float/double `LegacyPrecision` tests now only exercise `absl::HighPrecision`. Both are covered by absl's own tests. PiperOrigin-RevId: 1004665742
copybara-service
Bot
force-pushed
the
test_1003804305
branch
from
October 22, 2026 11:19
344b266 to
b37330f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
LegacyPrecisionand absl-only tests fromtsl/platform/numbers_test.cc.The
safe_strto*tests callabsl::SimpleAtoi/SimpleAtof/SimpleAtoddirectly, and the float/double
LegacyPrecisiontests now only exerciseabsl::HighPrecision. Both are covered by absl's own tests.