[Proc testing] Transform function-based proc tests into test procs in - #4874
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_972724962
branch
from
August 28, 2026 20:36
57210df to
84e73bf
Compare
copybara-service
Bot
force-pushed
the
test_972724962
branch
from
September 8, 2026 18:17
84e73bf to
a8f72f6
Compare
copybara-service
Bot
changed the title
TestFunctionTransformer from
copybara-service
Bot
force-pushed
the
test_972724962
branch
from
September 8, 2026 21:40
a8f72f6 to
8c0334d
Compare
`ParseAndTypecheckModule` so they can be executed by the test runner. This was done by serializing the transformed module to a string and sending it back through parsing & typechecking. In addition, this CL: - Preserves the lifetime of the original module in the `TypeInfo` cache, preventing heap-use-after-free crashes. Ideally, we'd completely remove all remnants of the old `Module` from `TypeInfo`, but this turned out to be nigh infeasible, after multiple attempts. - Skips compiler-derived functions in `Impl::ToString()` to avoid serialization errors during re-parsing. This was causing trait methods (e.g., `spawn`), which do not have bodies, to show up in the `ToString` output. These trait methods weren't parseable so now they're skipped. PiperOrigin-RevId: 978150035
copybara-service
Bot
force-pushed
the
test_972724962
branch
from
September 8, 2026 22:40
8c0334d to
13cbabb
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Proc testing] Transform function-based proc tests into test procs in
ParseAndTypecheckModuleso they can be executed by the test runner.This was done by serializing the transformed module to a string and
sending it back through parsing & typechecking.
In addition, this CL:
TypeInfocache,preventing heap-use-after-free crashes. Ideally, we'd completely
remove all remnants of the old
ModulefromTypeInfo, butthis turned out to be nigh infeasible, after multiple attempts.
Impl::ToString()to avoidserialization errors during re-parsing. This was causing trait methods
(e.g.,
spawn), which do not have bodies, to show up in theToStringoutput. These trait methods weren't parseable so now they'reskipped.