Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Looks like the cla error is due to an codex push which added a local email address meheff@<somerandommachine.net>. Feel free to just clone this and submit the fix internally. |
|
@meheff - we definitely shouldn't just clone & submit internally with a CLA violation flagged. Any chance you can get it fixed on your end? |
|
I realized I have not looked at the actual content of this PR. As such, I'm taking this as a bug report instead & will fix it separately. |
|
The CLA issue is that codex added meheff@mylocalmachinename.net as a coauthor. My own CLA is still up to date. I reopened this as a new PR #4949 without this problem. |
The arithmetic simplification pass checks whether
y << kcan overflow before rewriting:But it converted the unsigned maximum shift using signed ToInt64() which is incorrect as the semantics require interpretation of the value as an unsigned number.