Fix incorrect non-constexpr error in functions creating parametric structs. - #4933
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_975110867
branch
from
September 7, 2026 17:02
a7d3eee to
b5a9417
Compare
…ructs. The issue occurs when an equivalent parametric struct context has two creation sites in parametric functions. The parametric context, which is reused, would end up referring back to the instantiation expr at the first site (which is not usable at the 2nd site) before this change. Fixes #4895 PiperOrigin-RevId: 977935044
copybara-service
Bot
force-pushed
the
test_975110867
branch
from
September 8, 2026 15:50
b5a9417 to
4b4ce36
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect non-constexpr error in functions creating parametric structs.
The issue occurs when an equivalent parametric struct context has two creation sites in parametric functions. The parametric context, which is reused, would end up referring back to the instantiation expr at the first site (which is not usable at the 2nd site) before this change.
Fixes #4895