Fix incorrect rewriting of local variable references in legacy proc conversion. - #4934
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_977555773
branch
from
September 8, 2026 15:09
edc2b38 to
f780da9
Compare
copybara-service
Bot
changed the title
…onversion. When a member or state param is shadowed by a local variable in next() in the legacy proc, we would incorrectly rewrite references to the local variable as `self.foo` before this change. PiperOrigin-RevId: 977936216
copybara-service
Bot
force-pushed
the
test_977555773
branch
from
September 8, 2026 15:57
f780da9 to
503f74e
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect rewriting of local variable references in legacy proc conversion.
When a member or state param is shadowed by a local variable in next() in the legacy proc, we would incorrectly rewrite references to the local variable as
self.foobefore this change.