Skip to content

Don't build a shared library for embedded data #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marketchedai wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Don't build a shared library for embedded data #4993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions xls/build_rules/xls_cc_embed_data_rules.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ def get_embedded_data(
ctx.attr._absl_span[CcInfo].linking_context,
ctx.attr._libc_runtime[CcInfo].linking_context,
],
# Embedded data is only ever linked statically into its consumers, and
# building the shared variant breaks on macOS: the toolchain passes the
# ELF-only `-soname` to the Mach-O linker, which rejects it. Skipping
# the shared library avoids the dead artifact on every platform.
disallow_dynamic_library = True,
)
return CcInfo(compilation_context = comp_ctx, linking_context = link_ctx)

Expand Down
Loading