refactor(bigtable): move common otel mocks to testing_util - #16361
refactor(bigtable): move common otel mocks to testing_util#16361scotthart wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors OpenTelemetry metrics testing utilities by extracting duplicated mock classes (MockHistogram, MockCounter, MockMeter, MockMeterProvider) and the MakeAttributesMap helper function from Bigtable internal tests into shared testing utilities under google/cloud/testing_util. Feedback on the new headers suggests correcting the included OpenTelemetry headers to directly include the required KeyValueIterable and nostd types instead of relying on transitive or incorrect includes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16361 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 2237 2239 +2
Lines 210251 210227 -24
=======================================
- Hits 193928 193913 -15
+ Misses 16323 16314 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.