Skip to content

impl(bigtable): update observability integration test to test all metric types - #16363

Open
scotthart wants to merge 3 commits into
googleapis:mainfrom
scotthart:bigtable_client_schema_metrics_3
Open

impl(bigtable): update observability integration test to test all metric types#16363
scotthart wants to merge 3 commits into
googleapis:mainfrom
scotthart:bigtable_client_schema_metrics_3

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@scotthart
scotthart requested a review from a team as a code owner August 20, 2026 23:51
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Aug 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the observability integration tests to support both static and dynamic channel pools, redirects Cloud Monitoring metric exports to a local OpenTelemetry collector, and introduces a new test case VerifyOutstandingRpcsMetric for dynamic pools. It also refactors the metric verification logic using custom GTest matchers for improved readability. The feedback suggests replacing absl::string_view with std::string_view in two locations to comply with the repository style guide.

Comment thread google/cloud/bigtable/tests/observability_integration_test.cc Outdated
Comment thread google/cloud/bigtable/tests/observability_integration_test.cc Outdated
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.70370% with 104 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.23%. Comparing base (31a0d9f) to head (ae2bf11).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...d/bigtable/tests/observability_integration_test.cc 3.70% 104 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16363      +/-   ##
==========================================
- Coverage   92.23%   92.23%   -0.01%     
==========================================
  Files        2237     2237              
  Lines      210251   210269      +18     
==========================================
+ Hits       193928   193934       +6     
- Misses      16323    16335      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant