Repository navigation
Conversation
…ClientOptions - Align OpenTelemetry semantic conventions with v1.39 (server.address, server.port, rpc.system.name, rpc.response.status_code) - Remove unreleased deprecated RPC_SYSTEM constant in favor of canonical RPC_SYSTEM_NAME - Extract traceTransportOperation helper in TelemetryTrait to DRY transport operation tracing - Explicitly record exceptions as span events via recordException() - Add comprehensive docblocks explaining openTelemetryTracerProvider in ClientOptions
… and auth handler reconfiguration - Synchronously detach OTel scope in TracingMiddleware to avoid leaking context across unawaited async calls - Activate OTel span scope during promise wait() execution so retry delays and subsequent attempts inherit Client Request span context - Activate and detach scope around transport operations in TelemetryTrait::traceTransportOperation - Support reconfiguring TracerProviderInterface on already-wrapped AuthHttpHandler instances in CredentialsWrapper - Modernize array destructuring syntax in GapicClientTrait - Remove internal taxonomy shorthand from TracingMiddleware docblock - Add unit test coverage for promise wait/cancellation scope lifecycles and AuthHttpHandler reconfiguration
Decouple T5 spans (RetryDelay, RequestMarshaling, ResponseUnmarshaling, and AuthenticationRefresh) to focus the PR strictly on configuration/gating, T3 (Client Request), and T4 (Network Request).
…s and unused attributes
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #9573 with review updates in 8615bac:
TracingMiddleware.ApiExceptionerror attributes inGrpcTransportandTelemetryTrait.clientVersionfromgapicVersionand simplify telemetry options inGapicClientTraitandTelemetryTrait.