Skip to content

fix(Gax): address tracing review feedback and span lifecycle fixes - #9778

Open
bshaffer wants to merge 8 commits into
pr-9573from
feat/observability-t1-config-review
Open

bshaffer wants to merge 8 commits into
pr-9573from
feat/observability-t1-config-review

Conversation

@bshaffer

@bshaffer bshaffer commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Address code review feedback on #9780 (#9573) and refine span lifecycle handling:

  • Normalize gRPC status codes using string constants () and map HTTP status codes in for non-gRPC errors.
  • Detach the active OpenTelemetry context scope before ending the span in and , and catch in .
  • Propagate (, , ) from to transports, and wrap in a / inside () so invalid endpoints do not throw when instantiating transports directly.
  • Remove unused , , and the composer dependency, and clean up constants.

@bshaffer
bshaffer requested a review from a team as a code owner October 8, 2026 01:28
@bshaffer
bshaffer added this pull request to stack #9779 October 8, 2026 01:28
@google-cla

google-cla Bot commented Oct 8, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bshaffer bshaffer changed the title feat(Gax): implement Observability Phase 1 (Config, Client Request & Network Tracing) fix(Gax): address tracing review feedback and span lifecycle fixes Oct 8, 2026
@bshaffer
bshaffer removed this pull request from stack #9779 October 8, 2026 18:45
@bshaffer
bshaffer changed the base branch from main to pr-9573 October 8, 2026 18:45
@bshaffer
bshaffer requested review from a team as code owners October 8, 2026 18:45
@bshaffer
bshaffer added this pull request to stack #9782 October 8, 2026 18:45

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant