fix(spanner-dbapi): set realistic coverage threshold#17581
Draft
chalmerlowe wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .coveragerc configuration file for the google-cloud-spanner-dbapi-driver package. Specifically, it adds a minimum coverage threshold of 85% (fail_under = 85) and updates the path pattern for omitting the __init__.py file to support wildcard matching. There are no review comments, and we have no additional feedback to provide.
chalmerlowe
force-pushed
the
fix/spanner-dbapi-coverage-threshold
branch
from
e0a149c to
2faf6d8
Compare
chalmerlowe
force-pushed
the
fix/spanner-dbapi-coverage-threshold
branch
from
2faf6d8 to
c45e212
Compare
chalmerlowe
changed the title
brunoprado-ux
approved these changes
Jun 26, 2026
brunoprado-ux
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a coverage evaluation failure in
google-cloud-spanner-dbapi-driverby setting a realisticfail_underthreshold.Issue Details
A recent change to the global CI/CD pipeline (
unittest.yml) enforces a default coverage threshold of 99% for modified packages that do not define their ownfail_underin.coveragerc.This package historically lacked an explicit threshold in its configuration, and its current coverage sits around 89% (with some modules like
errors.pyat 64%). Consequently, any modification triggering checks fails against this new 99% default, even though coverage hasn't regressed.Solution
Explicitly set
fail_under = 85inpackages/google-cloud-spanner-dbapi-driver/.coveragercto match historical reality while maintaining a safety net against regression.