Repository navigation
Conversation
chingor13
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds Swift documentation comments to the generated _anyTypeUrl property, init(fromAny:) initializer, and _pack() method in the message template. It also updates the corresponding tests and adds a new test TestGenerateMessage_AnyPackableDocComments to verify the generated documentation comments. There are no review comments, and I have no feedback to provide.
chingor13
marked this pull request as ready for review
October 6, 2026 23:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds DocC comments to
_anyTypeUrl,init(fromAny:), and_pack()inmessage.gotmpl, documenting the type URL, unpacking semantics and throws error conditions, and packing semantics and throws error conditions.Part of googleapis/google-cloud-swift#1071.