Skip to content

fix: Fix AttributeError on RagManagedDb when calling create_corpus #6989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix AttributeError on RagManagedDb when calling create_corpus #6989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agentplatform/preview/rag/utils/_gapic_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,7 +1298,7 @@ def set_backend_config(
if backend_config.vector_db is not None:
vector_config = backend_config.vector_db
if vector_config is None:
rag_corpus.vector_db_config.rag_managed_db.CopyFrom(
rag_corpus.vector_db_config.rag_managed_db = (
GapicRagVectorDbConfig.RagManagedDb()
)
elif isinstance(vector_config, RagManagedDb):
Expand Down
2 changes: 1 addition & 1 deletion agentplatform/rag/utils/_gapic_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,7 @@ def set_backend_config(
if backend_config.vector_db is not None:
vector_config = backend_config.vector_db
if isinstance(vector_config, RagManagedDb):
rag_corpus.vector_db_config.rag_managed_db.CopyFrom(
rag_corpus.vector_db_config.rag_managed_db = (
GapicRagVectorDbConfig.RagManagedDb()
)
elif isinstance(vector_config, VertexVectorSearch):
Expand Down
12 changes: 12 additions & 0 deletions tests/unit/vertex_rag/test_rag_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,18 @@ def test_create_corpus_success(self):

rag_corpus_eq(rag_corpus, test_rag_constants.TEST_RAG_CORPUS)

@pytest.mark.usefixtures("create_rag_corpus_mock")
def test_create_corpus_rag_managed_db_success(self):
backend_config = rag.RagVectorDbConfig(
vector_db=rag.RagManagedDb()
)
rag_corpus = rag.create_corpus(
display_name=test_rag_constants.TEST_CORPUS_DISPLAY_NAME,
backend_config=backend_config,
)

rag_corpus_eq(rag_corpus, test_rag_constants.TEST_RAG_CORPUS)

@pytest.mark.usefixtures("create_rag_corpus_mock_vertex_vector_search")
def test_create_corpus_vertex_vector_search_success(self):
rag_corpus = rag.create_corpus(
Expand Down
2 changes: 1 addition & 1 deletion vertexai/preview/rag/utils/_gapic_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1304,7 +1304,7 @@ def set_backend_config(
if backend_config.vector_db is not None:
vector_config = backend_config.vector_db
if vector_config is None:
rag_corpus.vector_db_config.rag_managed_db.CopyFrom(
rag_corpus.vector_db_config.rag_managed_db = (
GapicRagVectorDbConfig.RagManagedDb()
)
elif isinstance(vector_config, RagManagedDb):
Expand Down
2 changes: 1 addition & 1 deletion vertexai/rag/utils/_gapic_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ def set_backend_config(
if backend_config.vector_db is not None:
vector_config = backend_config.vector_db
if isinstance(vector_config, RagManagedDb):
rag_corpus.vector_db_config.rag_managed_db.CopyFrom(
rag_corpus.vector_db_config.rag_managed_db = (
GapicRagVectorDbConfig.RagManagedDb()
)
elif isinstance(vector_config, VertexVectorSearch):
Expand Down
Loading