fontc operations: warn on unknown flags/filters (instead of exceptions) - #1219
Merged
simoncozens merged 3 commits intoAug 28, 2026
Merged
Conversation
RickyDaMa
force-pushed
the
fontc-unknown-flags-warn
branch
from
August 28, 2026 13:41
13b5af5 to
719fa9b
Compare
anthrotype
approved these changes
Aug 28, 2026
Contributor
Longer term we use gftools-builder3 which has fontc as a first-class citizen and not a somewhat hacky argument-wrapper for fontmake. But sure, we shall do this for the medium term. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unknown flags are now passed to fontc verbatim, which will still error if it was a fontmake flag, but otherwise provides a way to give fontc-specific args to fontc when it's being used. Unknown filters are now dropped.
Longer term maybe we should just expect users to use the fontc operations directly (with some extra ease of use in the default recipe provider)? Because bridging this gap is awkward and footgun-prone.
I was also in the locale of an outstanding question I happened to know the answer to, so I wrote that in :)