Repository navigation
fix: use maintained MinIO image in filesystem tests - #152
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coollabsio/minio, pinned toRELEASE.2025-10-15T17-29-55Z) instead of the removedminio/minio:latest, so theTest Filesystemsjob no longer panics ininitMinio().MINIO_ROOT_USER/MINIO_ROOT_PASSWORDvariables that the current MinIO image actually reads.config/filesystems.goand the workflow secrets are untouched.Why
The
Test Filesystemsworkflow was failing becauseminio/minio:latestno longer exists on Docker Hub. MinIO archived its OSS edition and removed the Docker Hub images, sodocker run minio/miniofails with a misleadingpull access denied ... repository does not exist, and the registry API now returns404forminio/minio. The panic happened ininitMinio()before any test logic ran, so the MinIO-backed filesystem paths (facades.Storage().Disk("minio")) were never exercised.This points the test container at
coollabsio/minio, a maintained community rebuild built from the official MinIO release: it is multi-arch and uses MinIO's officialdocker-entrypoint.sh, so theserver /datacommand and the S3 API used by the tests are unchanged. Container credentials move to the canonicalMINIO_ROOT_USER/MINIO_ROOT_PASSWORD, which is what the supported image reads.Verification:
gofmtis clean, andgo build ./...andgo vet ./tests/...pass locally. TheTest Filesystemsjob on this PR validates the MinIO container end-to-end.Follow-up (out of scope):
goravel/minio'sminio_test.gouses the same removed image and will need the same fix separately.