Repository navigation
fix: clear the translation cache as a sync.Map after framework#1548 - #155
Merged
hwbrzzl merged 1 commit intoSep 28, 2026
Merged
Conversation
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goravel/framework#1548 turned
translation.loadedfrom a nested map into async.Map.ValidationLangTestSuiteresets itthrough
go:linkname, which doesn't check types, so the old reset still compiles but no longer clears anything. Thecustom
requiredmessage leaks intoTestValidationTestSuiteand 4 tests fail in the framework's "Test In Example"job, on master and on every PR since goravel/framework#1548.
translationLoadedassync.Mapand callClear()inTearDownTest93850001) inrequireandreplaceThe bump is needed: this repo's CI builds the pinned framework (map), the framework's CI builds its master
(
sync.Map), and one declaration can't match both. Same kind of bump as #153.Tested against framework
93850001: the validation suites fail before and pass after,go test ./tests/...andTestMainTestSuitepass, golangci-lint clean.