Skip to content

fix: clear the translation cache as a sync.Map after framework#1548 - #155

Merged
hwbrzzl merged 1 commit into
goravel:masterfrom
darakanoit:darakanoit/translation-cache-reset
Sep 28, 2026
Merged

hwbrzzl merged 1 commit into
goravel:masterfrom
darakanoit:darakanoit/translation-cache-reset

Conversation

@darakanoit

@darakanoit darakanoit commented Sep 28, 2026 •

Copy link
Copy Markdown

goravel/framework#1548 turned translation.loaded from a nested map into a sync.Map. ValidationLangTestSuite resets it
through go:linkname, which doesn't check types, so the old reset still compiles but no longer clears anything. The
custom required message leaks into TestValidationTestSuite and 4 tests fail in the framework's "Test In Example"
job, on master and on every PR since goravel/framework#1548.

The bump is needed: this repo's CI builds the pinned framework (map), the framework's CI builds its master
(sync.Map), and one declaration can't match both. Same kind of bump as #153.

Tested against framework 93850001: the validation suites fail before and pass after, go test ./tests/... and
TestMainTestSuite pass, golangci-lint clean.

@hwbrzzl hwbrzzl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hwbrzzl
hwbrzzl merged commit cb147ea into goravel:master Sep 28, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants