Repository navigation
Conversation
Some platforms push queue messages to the application instead of letting a worker pull them (AWS Lambda SQS event source mappings, Pub/Sub push subscriptions). Worker.Process runs one reserved job with the exact worker semantics (retries through Release, JobWithShouldRetry, chains, failed jobs and Delete) and reports whether it was released, so these consumers don't have to copy the worker's logic. - call/processReservedJob take how to record a failed job: the worker loop keeps using failedJobChan, Process records it synchronously since no failed job goroutine runs outside Run - processReservedJob now returns (released, err); the worker loops ignore it as before
1 task done
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1573 +/- ##
==========================================
+ Coverage 72.85% 72.87% +0.01%
==========================================
Files 412 412
Lines 26820 26826 +6
==========================================
+ Hits 19541 19550 +9
+ Misses 7278 7275 -3
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JGamboa
force-pushed
the
feat/queue-worker-process
branch
from
October 18, 2026 20:35
7e2ddd6 to
d9ef709
Compare
…at/queue-worker-process # Conflicts: # queue/worker.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#1014
Adds
Worker.Process(ctx, job, queue). It runs one reserved job with the exact worker semantics:ReleaseandJobWithShouldRetry/tries;Delete.It also reports whether the job was released. This is for platforms that push messages to the app instead of letting the worker pull them, such as AWS Lambda SQS event source mappings or Pub/Sub push subscriptions. Today a consumer like that has to copy the private worker logic.
call/processReservedJobnow take how to record a failed job. The worker loop keeps usingfailedJobChan.Processrecords synchronously, because no failed-job goroutine runs outsideRun.processReservedJobreturns(released, err). The worker loops ignore the result, so their behaviour is unchanged.Opened as a draft to discuss the API in the issue: on
Worker(as here) vs on theQueuefacade.✅ Checks