Repository navigation
Conversation
Currently the stub was generating the `Http()` facade with a response of `client.Request` rather than the expected `client.Factory`. Signed-off-by: Adam Jimerson <vendion@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.18.x #1584 +/- ##
===========================================
+ Coverage 69.60% 72.99% +3.39%
===========================================
Files 384 412 +28
Lines 30242 28197 -2045
===========================================
- Hits 21050 20583 -467
+ Misses 8195 7612 -583
+ Partials 997 2 -995 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hwbrzzl
reviewed
Oct 20, 2026
hwbrzzl
left a comment
hwbrzzl
left a comment
Contributor
There was a problem hiding this comment.
Thanks, could you set the base branch to master? I'll handle other version if needed.
Contributor
Author
Yeah, I'll have to close this PR and open a new one due to not having write permissions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Currently the stub was generating the
Http()facade with a response ofclient.Requestrather than the expectedclient.Factory.Closes goravel/goravel#1021
✅ Checks