Repository navigation
chore: modernize code to Go 1.26 idioms - #1586
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
- Coverage 72.90% 72.84% -0.06%
==========================================
Files 412 412
Lines 26893 26817 -76
==========================================
- Hits 19606 19536 -70
+ Misses 7285 7280 -5
+ Partials 2 1 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The framework now requires Go 1.26, but a lot of the code is still written the pre-1.21 way. This PR moves it to the newer standard library features, which makes the code shorter and easier to read.
b.Loop()in benchmarks and drop the manual timer calls. The mail benchmark no longer runs one extra loop (i <= b.N).wg.Goinstead ofAdd/go/Donein the queue worker, process pool and log rotation.math/rand/v2in collect and docker helpers. This removes the shared generator and its mutex.slices,maps,strings.Cut/SplitSeq,min/maxandreflect.TypeFor.sortwithslices.Sort/SortFunc. Help output uses a stable sort now, so flags stay in name order inside each group.for range nloops,slices.Sorted(maps.Keys(m))andslices.Clonein production code.new(x)everywhere and deprecateconvert.Pointerandtranslation.Bool. Both still work and will be removed in a future version.