Skip to content

CET-3214: Add api-reviewers as CODEOWNERS co-owner - #127

Merged
rkeur7 merged 1 commit into
mainfrom
chore/codeowners-sa-api-reviewers
Oct 23, 2026
Merged

rkeur7 merged 1 commit into
mainfrom
chore/codeowners-sa-api-reviewers

Conversation

@rkeur7

@rkeur7 rkeur7 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Jira: CET-3214

Summary

  • CODEOWNERS: * @goshippo/solutions-architects @goshippo/api-reviewers (was Solutions Architects only).
  • Solutions Architects own the SDKs; API Reviewers are added so either team can satisfy the required code-owner review on main.

Required before this takes effect

CODEOWNERS entries only count when the team has write access to the repo. Neither solutions-architects nor api-reviewers currently has access here, so the code-owner rule falls back to anyone with write. A repo admin needs to:

  • Add solutions-architects as Admin
  • Add api-reviewers as Maintain
  • Remove engineering-enablement (currently Write)

🤖 Generated with Claude Code

@rkeur7
rkeur7 requested review from jfriedr and removed request for jfriedr October 22, 2026 20:36

@jfriedr jfriedr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rkeur7
rkeur7 merged commit 455ef91 into main Oct 23, 2026
4 checks passed
@rkeur7
rkeur7 deleted the chore/codeowners-sa-api-reviewers branch October 23, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants