Skip to content

CET-3214: Add api-reviewers as CODEOWNERS co-owner - #121

Merged
jfriedr merged 1 commit into
mainfrom
chore/codeowners-sa-api-reviewers
Oct 22, 2026
Merged

jfriedr merged 1 commit into
mainfrom
chore/codeowners-sa-api-reviewers

Conversation

@rkeur7

@rkeur7 rkeur7 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Jira: CET-3214

Summary

  • CODEOWNERS: * @goshippo/solutions-architects @goshippo/api-reviewers (was Solutions Architects only).
  • Solutions Architects own the SDKs; API Reviewers are added so either team can satisfy the required code-owner review on main.

Required before this takes effect

CODEOWNERS entries only count when the team has write access to the repo. solutions-architects already has Admin here; a repo admin needs to:

  • Add api-reviewers as Maintain
  • Remove engineering-enablement (currently Write)

🤖 Generated with Claude Code

@rkeur7
rkeur7 requested a review from a team as a code owner October 22, 2026 20:35
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor
Tests Skipped Failures Errors Time
17 0 💤 0 ❌ 0 🔥 25.915 ⏱

@rkeur7
rkeur7 requested a review from jfriedr October 22, 2026 20:36

@jfriedr jfriedr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfriedr
jfriedr merged commit bed8719 into main Oct 22, 2026
6 of 9 checks passed
@jfriedr
jfriedr deleted the chore/codeowners-sa-api-reviewers branch October 22, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants