Skip to content

SpinPol - #276

Open
chselz wants to merge 5 commits into
grimme-lab:mainfrom
chselz:new_spgfn
Open

chselz wants to merge 5 commits into
grimme-lab:mainfrom
chselz:new_spgfn

Conversation

@chselz

@chselz chselz commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

With this PR I try a new approach for the implementation of the spin polarization. 😅
Ref values were taken from tblite 0.7.0.
I also added an example which showcases the ease of use of the spin pol interaction.

Signed-off-by: Christian Selzer <s6chselz@uni-bonn.de>
Signed-off-by: Christian Selzer <s6chselz@uni-bonn.de>
Signed-off-by: Christian Selzer <s6chselz@uni-bonn.de>
Comment thread src/dxtb/_src/scf/unrolling/default.py Fixed
from .field import *
from .list import InteractionList, InteractionListCache
from .solvation import *
from .spin import *
@overload
def get_interaction(
self, name: Literal["SpinPolarization"]
) -> SpinPolarization: ...
) -> SpinPolarization: ...

@overload
def get_interaction(self, name: str) -> Interaction: ...
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.50772% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.54%. Comparing base (3b6a90f) to head (42e5969).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dxtb/_src/calculators/types/analytical.py 52.17% 11 Missing ⚠️
src/dxtb/_src/scf/pure/data.py 50.00% 10 Missing and 1 partial ⚠️
src/dxtb/_src/cli/driver.py 47.36% 10 Missing ⚠️
...c/components/interactions/spin/spinpolarization.py 90.66% 3 Missing and 4 partials ⚠️
src/dxtb/_src/scf/base.py 89.13% 4 Missing and 1 partial ⚠️
src/dxtb/_src/scf/implicit/base.py 42.85% 4 Missing ⚠️
src/dxtb/_src/scf/mixer/anderson.py 80.00% 2 Missing and 2 partials ⚠️
src/dxtb/_src/scf/pure/conversions.py 90.62% 0 Missing and 3 partials ⚠️
src/dxtb/_src/components/interactions/list.py 92.00% 2 Missing ⚠️
.../dxtb/_src/components/interactions/spin/factory.py 85.71% 1 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
+ Coverage   88.38%   88.54%   +0.16%     
==========================================
  Files         215      220       +5     
  Lines       10784    11101     +317     
  Branches     1241     1265      +24     
==========================================
+ Hits         9531     9829     +298     
- Misses        902      917      +15     
- Partials      351      355       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Christian Selzer <s6chselz@uni-bonn.de>
Signed-off-by: Christian Selzer <s6chselz@uni-bonn.de>

This branch was successfully deployed

1 active deployment
codecov — 42e5969d Deployed Oct 19, 2026 by chselz via Upload to Codecov #332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants