New overlay folder selection algorithm#45
Open
ziopio wants to merge 2 commits into
Open
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This new algorithm will pick up every available folder that satisfies these 2 contitions: - shares the same Major version number of the target version - it is equal or older then the target version Example: Give target OTP version: 28.5.0.2 Compatible folders selected to build an overlay: 28, 28.0.2, 28.3, 28.3.3, 28.5, 25.5.0.1, 28.5.0.2. The follwing forders would be ignored if they exists: 26, 27, 29, 28.5.0.3, 28.6 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems of the legacy system
The old algorithm assebles a predefined list of directories by splitting the OTP version and then assembles a hierarchical list of directories.
For 28.5.0.2 it will look for:
Ignoring any other directory; which means ignoring any other patch or addintion added in an OTP maintenance version that preceeded
28.5.0.2Changes
This new algorithm will pick up every available folder that satisfies these 2 contitions:
Example:
Give target OTP version: 28.5.0.2
Compatible folders selected to build an overlay:
28, 28.0.2, 28.3, 28.3.3, 28.5, 25.5.0.1, 28.5.0.2.
The follwing forders would be ignored if they exists:
26, 27, 29, 28.5.0.3, 28.6 ...
Notes
This change is very important to minimize the need to duplicate patches when an OTP version increments its maintenance version. In other words it lower the maintenance effort.
This change is quite "safe" as it will expand the amount of directories used but for this same reason it could also introduce regressions or applly more patches and files then expected.
I only tested with the
grispandgrisp_cryptoauthgrisp apps