Skip to content

Keep Studio empty-events state honest - #1814

Draft
groupthinking with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-studio-workbench-dead-end
Draft

Keep Studio empty-events state honest#1814
groupthinking with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-studio-workbench-dead-end

Conversation

Copilot AI commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Canonical issue

Linked automatically by the system.

Outcome

Completed Studio runs with events[] = [] no longer imply transcript evidence when only pack identity exists. The empty Events rail remains honest while preserving the existing pack architecture/artifacts export path.

Scope

  • Included:
    • Empty-events copy: studioEventsEmptyMessage() now branches on transcript presence instead of always mentioning transcript.
    • Studio wiring: OneLoopStudio passes hasTranscript into the empty-state helper.
    • Regression coverage: adds the pack-only completed-run case so this copy cannot drift back.
    if (input.hasTranscript) {
      return 'This run has no extracted events. Transcript and pack identity stay on this page.';
    }
    return 'This run has no extracted events. Pack identity stays on this page.';
  • Explicitly excluded:
    • Pack workbench promotion/export behavior
    • Transcript or event extraction logic
    • Unrelated web workspace typecheck failures outside this change

Risk

  • Risk level: low
  • Failure mode: Studio reverts to misleading empty-state copy for pack-only completed runs.
  • Rollback: revert the hasTranscript branch in studioEventsEmptyMessage() and the caller wiring in OneLoopStudio.

Verification

Head SHA: 130d78a

  • Focused tests — cd apps/web && npm test -- --run src/lib/__tests__/studio-pipeline-status.test.ts src/lib/__tests__/action-surface.test.ts src/store/__tests__/dashboard-store.test.ts
  • Required CI
  • Review threads resolved

Production evidence

Not applicable for this change set: UI copy/state behavior only; no production receipt or deploy evidence was required for acceptance.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Sep 8, 2026 11:23pm UTC

Copilot AI and others added 2 commits September 8, 2026 23:21
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Studio workbench dead-end when events array is empty Keep Studio empty-events state honest Sep 8, 2026
Copilot AI requested a review from groupthinking September 8, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Studio workbench dead-end when events[] is empty

2 participants