fix(reconciliation): accept same-repo qualified issue refs - #1825
fix(reconciliation): accept same-repo qualified issue refs#1825groupthinking with Copilot wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Actions triage — PR #1825
Conclusion: not failure and not cancelled. Every GitHub Actions workflow on 8585b5873f442413395786aed2e8848b96dea6ad concluded action_required.
Jobs / error: none. Representative CI run 34389853937: 0 jobs, log not found. Same empty suite for PR Checks (34389851375, 34389956478), E2E, Secret Scan, Security Scan, CodeQL, Dependency Review, Auto Label, pr-iteration-loop, and Dependabot Auto Merge.
Root cause: GitHub is holding first-run workflows from Copilot (app/copilot-swe-agent) until a maintainer approves them. This is an approval gate, not a code regression. The draft PR is plan-only (0 files changed). Vercel checks already passed; Copilot cloud agent is still running.
Next step: no code fix. Approve workflows on the PR if CI should run; otherwise wait for Copilot to push real changes. Slack CoS post was not sent — Composio slack / slackbot have no active connection.
Sent by Cursor Automation: Triage failed GitHub Actions
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
There was a problem hiding this comment.
🟡 Changes recommended
The regression test checks identifiers only and would not detect incorrect matching behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates reconciliation to recognize same-repository qualified issue references while excluding cross-repository references.
Changes:
- Builds an escaped repository-qualified closing-reference regex.
- Adds regression coverage, though it does not exercise matching behavior.
File summaries
| File | Description |
|---|---|
.github/workflows/repository-reconciliation.yml |
Accepts bare and same-repository issue references. |
tests/unit/test_repository_reconciliation_workflow.py |
Adds structural assertions for the parser change. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| assert "escapedRepoFullName" in script, ( | ||
| "Closing-reference parsing should escape the current repo name so fully qualified" | ||
| " same-repo references are accepted." | ||
| ) | ||
| assert "repoFullName" in script, ( | ||
| "Closing-reference parsing should derive the fully qualified repo prefix from" | ||
| " the current workflow repository context." | ||
| ) |
PR Iteration Loop — verification updateCheckpoint: What changed on this head
Verification
Duplicate-issue noteThis checkpoint's failure signature spawned 6 separate near-duplicate issues (#1833, #1834, #1835, #1836, #1837, #1839) plus this PR (#1840), all within a 3-minute window, all describing the same root cause. Chart: Next stepOnce this PR's own CI checks (currently Recommended patternAgentic Workflows — the root cause is declarative CI surface (workflow_dispatch options + sentinel regex) drifting from its own shell script's implemented arguments; fixing and regression-testing that drift is exactly what natural-language-authored GitHub Actions workflows are built to catch and correct, more directly than Chopin, Continuous AI, or Autoloop.
|



Canonical issue
Handled by automation.
Outcome
The repository drift report was falsely flagging PRs as missing a canonical issue when they used fully qualified same-repo references. This change makes reconciliation treat
Closes groupthinking/EventRelay#123the same asCloses #123, while continuing to ignore other-repo references.Scope
Risk
Verification
Current head:
Focused workflow unit coverage for repository reconciliation parsing.
Manual smoke check for:
Closes #1822Closes groupthinking/EventRelay#1822Closes other/repo#1822Focused tests
Required CI
Review threads resolved
Production evidence
Not applicable; this is a GitHub Actions workflow change. Runtime-equivalent evidence is the regex smoke check showing same-repo qualified refs match and other-repo qualified refs do not.
Agent handoff