Allow full control over User-Agent header - #2492
Open
teodordelibasic-db wants to merge 2 commits into
Open
Conversation
Signed-off-by: teodordelibasic-db <teodor.delibasic@databricks.com>
nathanielford
self-requested a review
September 1, 2026 23:49
|
nathanielford
approved these changes
Sep 1, 2026
nathanielford
left a comment
nathanielford
left a comment
Contributor
There was a problem hiding this comment.
Looks good! If you sign the CLA we can get this merged. Small caveat; it's unclear if there will be another tonic release, so this may only ever exist in the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, tonic appends its user-agent string (
tonic/x.x.x) to any existingUser-Agentheader on a request. This means middleware and applications built on top of tonic cannot have full control over theUser-Agentheader.This addresses the original request in #970 for full control over the User-Agent header.
Solution
Skip setting the
User-Agentheader if it has already been set on the request, giving users complete control when needed.Testing
Updated existing unit tests to verify the new behavior preserves the request's user-agent unchanged.