Move UsageStore logic to using Grid quota counting instead of RCS emails - #4890
Open
junyuanxue wants to merge 1 commit into
Open
Conversation
junyuanxue
force-pushed
the
08-25-move_usagestore_logic_to_using_grid_quota_counting_instead_of_rcs_emails
branch
from
August 26, 2026 13:10
35ab670 to
18941b0
Compare
junyuanxue
force-pushed
the
08-25-move_usagestore_logic_to_using_grid_quota_counting_instead_of_rcs_emails
branch
from
August 26, 2026 14:49
18941b0 to
a65e9d8
Compare
junyuanxue
marked this pull request as ready for review
August 26, 2026 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR moves the logic behind supplier usage status / summary within
UsageStoreover to using the new quota counting logic, instead of relying on parsing emails from RCS.UsageStoreno longer requires fetching from S3, I've made it no longer inheriting fromBaseStore. However as it still maintains an in-memory store of over-quota agencies (to be used for theis:under-quotasearch filter), it still needs a scheduler that refreshes the store on an interval.exceededlogic from>to>=, as we should start surfacing warning when the quota is full, not just exceeded. This is confirmed by the behaviours below. The wording 'exceeded' is a bit misleading, but as it's used quite extensively, I've refrained from not changing it everywhere.How should a reviewer test this change?
--use-TESTflagis:under-quotafilter, the images with the arrow icon should disappear:Tested? Documented?