Skip to content

issue-18 - #40

Open
sofie-99 wants to merge 38 commits into
hack4impact-calpoly:mainfrom
BrianLiDesign:main
Open

sofie-99 wants to merge 38 commits into
hack4impact-calpoly:mainfrom
BrianLiDesign:main

Conversation

@sofie-99

@sofie-99 sofie-99 commented Oct 7, 2026

Copy link
Copy Markdown

Developer: Sofie Saini

Closes #18

Pull Request Summary

finish issue 18

Modifications

i'm sure i touched every file atp. made acceptance-runner.ts, database-smoke.ts, acceptance-runner.ts, and controlled-server.ts

Testing Considerations

npm run deve worked, there are no problems

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

{put screenshots of your change, or even better a screencast displaying the functionality}

ryanhu021 and others added 28 commits October 19, 2024 14:01
Co-authored-by: Cursor <cursoragent@cursor.com>
Closes #5. Adds the About and Contact routes using the shared layout and navbar. Removes unused root HTML files. Verified with lint, production build, route checks, and CI on Node 18, 20, and 22.
Marks the current route in the shared navbar and exposes the active link with accessible semantics.

Closes #6.
Adds the Menu and Specials pages, fetches shared offerings through /api/offerings, filters specials, and records issue #2 as the required API dependency.
* hi

* Fix missing newline at end of route.ts

* fix(api): restore starter example route

Keep the MongoDB starter reference required by AGENTS.md. Issue #2 adds the mock offerings API without replacing the existing example.

---------

Co-authored-by: Brian Li <brian.li.social@gmail.com>
Establish the browser-safe creation and response contracts for issue #14. Replace the placeholder test script with real HTTP regression checks while retaining the 16-item mock menu and three specials.
Closes #21. Version the approved independent assignments and onboarding guidance, preserve final integration evidence, and reconcile the API guide with the revised issue scopes.
* feat(offerings): add management page and controlled preview

Implement the Issue 20 management form with validation, status feedback, and a separate controlled-response preview. Add focused tests and labeled browser evidence.

Closes #20

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(offerings): preserve form state and honor submission contract

* test(offerings): provide browser navigator across Node versions

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Brian Li <brian.li.social@gmail.com>
* finished issue

* feat(offerings): complete special control and independent verification

---------

Co-authored-by: Brian Li <brian.li.social@gmail.com>
* created offering of drinks

* fix: prepare offering data for review

* feat(offerings): implement storage and repeatable seeding

---------

Co-authored-by: Brian Li <brian.li.social@gmail.com>
* feat: implement milestone 3 release foundation (#30)

* fix: harden API feedback and finalize release evidence

* docs: prepare milestone 3 foundation merge and handoff
…st (#28)

Complete the standalone loopback acceptance runner, controlled HTTP/CLI self-tests, owned disposable database lifecycle checks, and demonstration checklist with a pending six-person evidence matrix. Preserve the current application contract, authenticated writes, anonymous GET, and existing regressions.

Validated with 118 tests, lint, typecheck, production build, independent Standards/Spec review, and passing PR CI. Live Atlas and team meeting evidence remains under #12.

Closes #18
@gitguardian

gitguardian Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Bearer Token e06b7c9 tests/controlled-server.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

* feat:Get and Post

* feat:delete orginal test

* feat: complete offering handlers and validation (#16)

---------

Co-authored-by: Brian Li <brian.li.social@gmail.com>
vedikachau and others added 9 commits October 13, 2026 00:08
* added 3 tests

* test(customer-pages): record usability and contribution evidence

---------

Co-authored-by: Brian Li <brian.li.social@gmail.com>
* feat(offerings): add management page and controlled preview

Implement the Issue 20 management form with validation, status feedback, and a separate controlled-response preview. Add focused tests and labeled browser evidence.

Closes #20

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test(manage-offerings): verify invalid-save and reset behavior

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs(milestone-3): add issue 34 browser evidence

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore: add required preflight checks

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs(management): record verified form and keyboard evidence

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Brian Li <brian.li.social@gmail.com>
* test: 3 vitest cases

* fix: changed name of file live-acceptance.tests.ts to live-acceptance.test.ts

* fix: merged tests/live-acceptance.test.ts into tests/unit/live-acceptance.test.ts

* docs: test case names and explaination

---------

Co-authored-by: Brian Li <brian.li.social@gmail.com>
* test: test offering storage and safe seeding

* test: enable offering storage cases and record verification

---------

Co-authored-by: Brian Li <brian.li.social@gmail.com>
Updated verification date for menu and specials.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants