Repository navigation
Conversation
The repository used CodeQL default setup, which never ran on pull requests from forks. Branch protection requires the Analyze (actions), Analyze (javascript-typescript) and Analyze (ruby) checks, so fork pull requests could only merge with an admin bypass. Switch to an advanced-setup workflow with the same languages, build mode and categories, so existing alerts carry over and the required check names stay the same. Default setup must be disabled when this merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL never ran on pull requests from forks, so three required checks never reported on them.
The problem
mainand for pull requests from branches in this repository.mainrequiresAnalyze (actions),Analyze (javascript-typescript)andAnalyze (ruby).Analyzejobs and theCodeQLresult check.The change
Adds
.github/workflows/codeql.yml, a CodeQL advanced-setup workflow. It keeps what default setup was doing:actions,javascript-typescriptandruby, withbuild-mode: none. These are the same as default setup, taken from its run logs./language:<language>, the same as default setup, so existing alerts carry over.Analyze (<language>), so they still match the required checks.main, including from forks;main;actionlintpasses on all six workflows. Brakeman's SARIF upload already works from fork pull requests here (theBrakemancheck shows up on #219), so CodeQL's upload should work the same way. Step 5 below confirms that.Rollout (order matters)
GitHub rejects advanced-setup results while default setup is turned on, so this pull request's own CodeQL jobs will fail until step 2.
CodeQLjobs on this pull request and confirm all threeAnalyzechecks pass.Analyzechecks run and pass.While steps 2–4 are in progress, other open pull requests won't get CodeQL results. Re-run or push to them after merging.
Not changed
brakeman.ymlsetscontinue-on-error: true, so the requiredBrakeman Scancheck can't fail. Brakeman still blocks merges through CI'sscan_ruby.ci.yml.