Repository navigation
Hide language filter row by default, add settings toggle - #168
Merged
Merged
Conversation
The "All languages" chip row above the Home and Explore feeds takes up vertical space for users who don't filter by language. Add a show_language_filter preference (default off) with a Settings switch. When the row is hidden, any previously selected language is reset so it cannot keep filtering invisibly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LanguageFilterRow) on Home and Explore is now hidden by default.show_language_filterpreference (defaultfalse) inPreferencesManager, exposed as a "Show language filter" switch in Settings.TimelineScreen/ExploreScreentake ashowLanguageFilterparameter (fed fromAppViewModel.preferencesManagerinHackersPubApp) and skip the row and its divider when it is off.Notes
!!; new strings live instrings.xml(§11.1).Test plan
./gradlew :app:lintDebugSettingsScreenTest,ExploreViewModelTest,TimelineViewModelTest🤖 Generated with Claude Code