Skip to content

Hide language filter row by default, add settings toggle - #168

Merged
malkoG merged 1 commit into
hackers-pub:mainfrom
malkoG:feat/language-filter-opt-out
Sep 29, 2026
Merged

malkoG merged 1 commit into
hackers-pub:mainfrom
malkoG:feat/language-filter-opt-out

Conversation

@malkoG

@malkoG malkoG commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • The "All languages" chip row (LanguageFilterRow) on Home and Explore is now hidden by default.
  • New show_language_filter preference (default false) in PreferencesManager, exposed as a "Show language filter" switch in Settings.
  • TimelineScreen / ExploreScreen take a showLanguageFilter parameter (fed from AppViewModel.preferencesManager in HackersPubApp) and skip the row and its divider when it is off.
  • When the row is hidden, any selected language is reset to "all", so a filter chosen earlier cannot keep applying invisibly.

Notes

  • Existing users will see the row disappear after updating until they enable the switch. Say so if you'd rather default to on for them.
  • No new !!; new strings live in strings.xml (§11.1).

Test plan

  • ./gradlew :app:lintDebug
  • SettingsScreenTest, ExploreViewModelTest, TimelineViewModelTest
  • Manual: toggle in Settings shows/hides the row on Home and Explore
  • Manual: select a language, turn the switch off, confirm the feed returns to all languages

🤖 Generated with Claude Code

The "All languages" chip row above the Home and Explore feeds takes up
vertical space for users who don't filter by language. Add a
show_language_filter preference (default off) with a Settings switch.
When the row is hidden, any previously selected language is reset so it
cannot keep filtering invisibly.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2b74c212-7098-4b31-88f1-19e4624896e7

📥 Commits

Reviewing files that changed from the base of the PR and between fcadd12 and eed000e.

📒 Files selected for processing (7)
  • app/src/main/java/pub/hackers/android/data/local/PreferencesManager.kt
  • app/src/main/java/pub/hackers/android/ui/HackersPubApp.kt
  • app/src/main/java/pub/hackers/android/ui/screens/explore/ExploreScreen.kt
  • app/src/main/java/pub/hackers/android/ui/screens/settings/SettingsScreen.kt
  • app/src/main/java/pub/hackers/android/ui/screens/settings/SettingsViewModel.kt
  • app/src/main/java/pub/hackers/android/ui/screens/timeline/TimelineScreen.kt
  • app/src/main/res/values/strings.xml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@malkoG
malkoG merged commit f1f76bc into hackers-pub:main Sep 29, 2026
1 of 2 checks passed
@malkoG
malkoG deleted the feat/language-filter-opt-out branch September 29, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant