Skip to content

Making BSseqTstat and BSseqStat inherit from GRanges instead of hasGRanges has significant benefits #158

Open

Description

@hpages

Hi @kasperdanielhansen,

Right now BSseqTstat and BSseqStat inherit from hasGRanges instead of simply inheriting from GRanges. IIRC this design decision was made a long time ago but I'm not sure what the reason for this choice was.

FWIW it seems that simply inheriting from GRanges has significant benefits over the hasGRanges solution. Note that making that change is relatively straightforward. I'm submitting a PR in case you're interested. See #157.

Let me know if I'm missing something.

Thanks,
H.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions