Repository navigation
feat(sql): UPDATE and DELETE on custom tables - #56
Merged
Merged
Conversation
NULL against a number compared as equal, which is not a total order, so NULLs ended up between numbers (and a sort may panic on that). NULL now sorts lowest, then booleans, numbers and strings, in both the plain and the aggregate paths.
Custom table cells are text, so age + 1 was NULL. A string that parses as a number now counts as that number in + - * /.
Rows are rewritten like INSERT does: expressions and WHERE see the table as it was before the statement, NOT NULL and UNIQUE are checked, the change is persisted atomically and a failure leaves the table as it was. Only statements on blocks need --write-back now.
The test was defined twice, which stopped the test target from compiling.
Both overlap with what SQL (WHERE, under()) and mq already cover. BREAKING CHANGE: DocumentStore::query(), Query, QueryResult, LintViolation and the `mq-db lint` subcommand are removed.
…d-lint refactor!: remove the Query builder and the lint command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rows are rewritten like INSERT does: expressions and WHERE see the table as it was before the statement, NOT NULL and UNIQUE are checked, the change is persisted atomically and a failure leaves the table as it was. Only statements on blocks need --write-back now.