Repository navigation
Conversation
Adding a variant or field is no longer a breaking change for downstream crates. This also keeps exhaustive matches on `mq_markdown::Node` from breaking when feature unification enables `callout`, `embed` or `wikilink`. - enums: Node, Selector, RuntimeValue, AST Expr/Literal/Pattern and operators, and the error types (RuntimeError, SyntaxError, ModuleError, TypeError, HirError, ...) - structs: Error and the option/config types (ConversionOptions, FormatterConfig, TypeCheckerOptions, RenderOptions, RetryConfig, ChromiumWaitConfig, ...), each with `with_*` builder methods since struct literals are no longer allowed outside the defining crate - add HirError::symbol() so the exhaustive match stays in mq-hir - CST types and AstNode are intentionally left exhaustive BREAKING CHANGE: exhaustive matches on the listed enums need a wildcard arm, and the listed structs can no longer be built with struct literals outside their defining crate. Use `Default` and the `with_*` methods.
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a variant or field is no longer a breaking change for downstream crates. This also keeps exhaustive matches on
mq_markdown::Nodefrom breaking when feature unification enablescallout,embedorwikilink.Type of Change
Checklist
cargo fmtandcargo clippyand addressed any warningsjust test-alland all tests pass/docs, crateREADME.md) if neededAdditional Context