Skip to content

🧹 chore: remove deprecated builtins and dead code, split large test modules - #2627

Merged
harehare merged 9 commits into
mainfrom
chore/remove-deprecated-and-dead-code
Oct 20, 2026
Merged

harehare merged 9 commits into
mainfrom
chore/remove-deprecated-and-dead-code

Conversation

@harehare

Copy link
Copy Markdown
Owner

Summary

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • 📝 Documentation
  • ⚡ Performance
  • ✅ Test
  • 📦 Build / dependencies
  • 👷 CI

Checklist

  • I ran cargo fmt and cargo clippy and addressed any warnings
  • I ran just test-all and all tests pass
  • I added or updated tests covering this change
  • I updated relevant documentation (/docs, crate README.md) if needed
  • I added a changelog entry if this is a user-facing change

Additional Context

Rewrite em dashes in comments, docs, READMEs and skills. Runtime output
strings are left as they are. Plain code spans replace intra-doc links to
private items so cargo doc reports no warnings.
RuntimeError::IndexOutOfBounds, InternalError, UnexpectedBreak and
UnexpectedContinue, and cst::ParseError::ExpectedClosingBracket, along with
their hints, labels and test cases.
Add tests for the is_h1..is_h6 and is_h_level helpers, the node kind
predicates, is_markdown, markdowns, is_bytes, sort_by, uniq,
to_date_iso8601, stream_lines, stream_chunks, stream_bytes and load_markdown.
Symbol::is_deprecated flagged any doc line that mentioned the word, while the
LSP hover and the wasm hover used a stricter marker check. Move the strict
check into mq-hir and use it in all three places.
builtin.rs, cst/parser.rs, ast/parser.rs and mq-run/cli.rs each shrink by
about 40 to 65 percent. No test changes.
formatter.rs, mq-check/builtin.rs, mq-lsp/server.rs, mq-test/runner.rs,
mq-dap/adapter.rs, tarn/bytecode.rs, mq-ffi/lib.rs and builtin/convert.rs.
No test changes.
Replace the 16 positional arguments with a CrawlerOptions struct and fix the
stale usage example in the crate docs.
Group the state of the module prelude scan, the directory walk and the
parameter binding into structs. The add_breakpoint_with_options allow was
not needed.
@harehare
harehare force-pushed the chore/remove-deprecated-and-dead-code branch from bdf7850 to a7dbd00 Compare October 20, 2026 14:47
@codspeed

codspeed Bot commented Oct 20, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 10 skipped benchmarks1


Comparing chore/remove-deprecated-and-dead-code (a7dbd00) with main (7eaefd4)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@harehare
harehare merged commit 28bdabb into main Oct 20, 2026
18 checks passed
@harehare
harehare deleted the chore/remove-deprecated-and-dead-code branch October 20, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant