Skip to content

🐛 fix(lang): hint dict key access for selectors written after an iden - #2708

Merged
harehare merged 3 commits into
mainfrom
fix/dict-access-selector-hint
Oct 27, 2026
Merged

harehare merged 3 commits into
mainfrom
fix/dict-access-selector-hint

Conversation

@harehare

@harehare harehare commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

Close #2591

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • 📝 Documentation
  • ⚡ Performance
  • ✅ Test
  • 📦 Build / dependencies
  • 👷 CI

Checklist

  • I ran cargo fmt and cargo clippy and addressed any warnings
  • I ran just test-all and all tests pass
  • I added or updated tests covering this change
  • I updated relevant documentation (/docs, crate README.md) if needed

Additional Context

@codspeed

codspeed Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 10 skipped benchmarks1


Comparing fix/dict-access-selector-hint (7edcceb) with main (60f2820)2

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (5f597e4) during the generation of this report, so 60f2820 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@harehare
harehare merged commit bd7b48c into main Oct 27, 2026
14 checks passed
@harehare
harehare deleted the fix/dict-access-selector-hint branch October 27, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

d.a on a dict gives "Unknown selector" with no hint to use d["a"]

1 participant