Repository navigation
Conversation
…le declarations A module now errors when it binds the same name through `def`, or through a `def` and a `let`/`var`. Redeclaring `module m` keeps extending the existing module, but a member already bound by an earlier declaration in the same scope is rejected instead of silently replaced. Document the rule in modules_and_imports.md.
Merging this PR will not alter performance
Comparing Footnotes
|
…modules The sibling-extension check now tracks full qualified member paths and descends into nested module bodies, so `outer::inner::a` declared across two `outer` extensions is rejected instead of silently replaced. The check also runs for function and block bodies and for the directive list of an imported or included file. An imported file that binds the same name through `def` or `let` more than once is rejected before its functions are compiled.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A module now errors when it binds the same name through
def, or through adefand alet/var. Redeclaringmodule mkeeps extending the existing module, but a member already bound by an earlier declaration in the same scope is rejected instead of silently replaced. Document the rule in modules_and_imports.md.Type of Change
Checklist
cargo fmtandcargo clippyand addressed any warningsjust test-alland all tests pass/docs, crateREADME.md) if neededAdditional Context