Emit boolean defaults as true or false - #145
Merged
Merged
Conversation
A payload member or register declaring a defaultValue with interfaceType bool generated a numeric literal, so the emitted property did not compile. The default assignment now takes the resolved interface type and emits true or false for a boolean.
bruno-f-cruz
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A payload member or register declaring a
defaultValuealongsideinterfaceType: boolgenerated a numeric literal instead of a boolean value, so the emitted property did not compile.GetDefaultValueAssignmentnow takes the resolved interface type and emitstrueorfalsein the case ofbool.Notes for review
This is half of #144. The other half is a boolean member that also declares a
length, where the format path returns the raw expression without checking whether the member resolved to a scalar. It is a separate defect in a different code path and wants its own tests.