Update workflow actions to node24 - #147
Merged
Merged
Conversation
Every action moves to the major that runs on node24, which clears the deprecation warning reported on each run. The versions match the repositories that have already moved. The uv setup follows harp-tech/python at an exact version, since that action no longer publishes moving major tags. The cache is enabled and the interop lock file is now committed, so the cache key changes with the dependencies and the interop test resolves the same versions on every run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every action now runs on node24 and both the node20 deprecation warning, and the warning reporting that the uv cache had no dependency file, are gone.
setup-uv
This one needs an exact version rather than a major.
astral-sh/setup-uvstopped publishing moving major and minor tags at v8.0.0 as a supply chain measure, so@v8does not resolve and the last major tag is@v7.The pin follows
harp-tech/pythonat v8.3.2, in preference to the newer v9 and v10. The generated Python interface is written against that project and the interop test exercises it, so running the test in the same CI context makes the most sense.The interop lock file
tests/Python/uv.lockis now committed and the.gitignoreentry is gone. It was ignored while the dependencies were pinned to a pyharp pull request commit rather than to a published release, and that has not been true since the pins becameharp-protocol>=0.5.0andharp-device>=0.5.0from PyPI. This means the uv cache now has a key that changes with the dependencies, and the interop test resolves the same versions on every run.