Report the toolkit version in the header - #42
Merged
Merged
Conversation
The report header gains a row naming the build of harp.toolkit that produced it, read from the assembly informational version.
glopesdev
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The report header gains a Toolkit version row, read from the assembly informational version, which is the same value
--versionprints.The header already pinned the protocol commit and the generators package, so a shared report recorded which specification text it was checked against and which register set was expected, but not which toolkit version produced it. The full string is shown, so the provenance is legible in the HTML itself. The commit suffix is present on release builds too, since it comes from the SDK appending
SourceRevisionIdthrough the SourceLink support built into .NET 8.