Take the firmware file as an update argument - #43
Merged
Merged
Conversation
The firmware path is now the argument of the update command, matching how generate takes its metadata path, so the required input needs no option name at all. --path is kept as a hidden option for one version, and a parse-time validator rejects supplying both rather than preferring one, since a script migrating half way would otherwise flash a different file. Option descriptions follow the imperative voice for actions and a noun phrase for values, and --output no longer repeats a default that System.CommandLine already renders. That default is now constructed from a relative path, so help shows it as a dot.
glopesdev
force-pushed
the
cli-consistency
branch
from
September 14, 2026 16:49
4db9d60 to
51f7d64
Compare
bruno-f-cruz
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updatenow takes the firmware file as its argument rather than through a required--pathoption, matching howgeneratealready takes its metadata path. A required option is a contradiction in terms, and the best name for a command's sole required input is no name at all.--pathis kept as a hidden option for one version, sinceupdateis the oldest released command and possibly is used in old scripts. A parse-time validator rejects supplying both, so a script migrating half way does not flash the wrong file to a device.Option descriptions
Applied the imperative voice for actions and a noun phrase for values, to
--port,--timeout,--forceand--implementationoption descriptions.