Repository navigation
Fix read_pos race condition and add dev tooling - #1
Merged
Merged
Conversation
Replace plain stores on read_pos with compare_exchange_weak in both push and pop to prevent the cursor from moving backwards when producer and consumer race on overwrites. Add Docker-based dev workflow (Dockerfile, docker-compose.yml, Makefile), GitHub Actions CI (clippy, fmt, test, miri), and git pre-commit hook that auto-activates via Makefile.
hasanzakeri
added a commit
that referenced
this pull request
Mar 12, 2026
This reverts commit 775d3fc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push(overwrite path) andpopused plainstoreonread_pos. When the producer overwrites while the consumer is mid-pop, the consumer's store could moveread_posbackwards, causing skipped values and gaps larger than buffer capacity. Fixed by usingcompare_exchange_weakon both sides.make test,make clippy,make ci)..githooks/, auto-configured on firstmakeinvocation — no tools to install.Test plan
make cipasses (clippy clean, fmt clean, 18 tests pass)unsafeinsrc/make fuzzfor local 10-min run