Repository navigation
Conversation
Test Results 33 files 66 suites 3m 13s ⏱️ Results for commit 1b72ec5. ♻️ This comment has been updated with latest results. |
…-dialog-for-version-text-box
ihar-tsykala
marked this pull request as ready for review
October 7, 2026 12:11
Pyatakov
approved these changes
Oct 7, 2026
Pyatakov
deleted the
feat/6776-add-validation-error-on-publish-dialog-for-version-text-box
branch
October 7, 2026 12:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In the Publish dialog for a policy or a tool, a version the dialog does not accept (a letter, an empty field, or a version not greater than the previous one) only turned the Publish button grey, with no reason shown. For tools the "not greater" case was not even caught: the dialog let it through and the backend rejected the publish afterwards.
Both dialogs now show a message under the version field once it has been edited or touched: "Version is required", "Version must contain only numbers separated by dots, for example 1, 1.0 or 1.0.0", or "Version must be greater than ". The field gets the existing red border, and the message and the button read the same check, so they always agree. The tool dialog now compares with previousVersion, as the policy dialog and the backend do, and the tool list and tool editor now pass the tool into the dialog.
The accepted version format and the publish request are unchanged. The schema-template publish and schema set-version dialogs are not touched.
Fixes #6776
Checklist