Follow HLint suggestion: use <$> - #12015

Open

philderbeast wants to merge 27 commits into

haskell:masterfrom

cabalism:hlint/use-fmap-operator

philderbeast commented Jun 24, 2026

Collaborator

See #9110. Discharges and no longer ignores HLint's "use <$>" suggestion so that this will be suggested by our CI linting.

A similar suggestion, "use fmap", was merged earlier, with #11742.

There were some cascading suggestions that I tackled individually. I'll squash commits before applying the merge label if this pull request is approved.

Patches conform to the coding conventions.
Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

philderbeast marked this pull request as draft

June 24, 2026 01:47

philderbeast force-pushed the hlint/use-fmap-operator branch 6 times, most recently from 032d9c5 to c0f2629 Compare

June 24, 2026 02:22

philderbeast marked this pull request as ready for review

June 24, 2026 02:22

philderbeast force-pushed the hlint/use-fmap-operator branch from c0f2629 to d6f48d1 Compare

June 26, 2026 00:13

philderbeast added the attention: needs-review label

philderbeast force-pushed the hlint/use-fmap-operator branch from d6f48d1 to 388296c Compare

July 1, 2026 18:35

Bodigrim reviewed

View reviewed changes

cabal-install/src/Distribution/Client/IndexUtils/ActiveRepos.hs Outdated

Bodigrim reviewed

View reviewed changes

cabal-install/src/Distribution/Client/FileMonitor.hs Outdated

Bodigrim reviewed

View reviewed changes

cabal-install/src/Distribution/Client/ProjectOrchestration.hs Outdated

Bodigrim reviewed

View reviewed changes

cabal-install/src/Distribution/Client/TargetSelector.hs Outdated

Bodigrim reviewed

View reviewed changes

cabal-install/tests/UnitTests/Distribution/Client/ArbitraryInstances.hs Outdated

Bodigrim reviewed

View reviewed changes

Cabal/src/Distribution/Simple/Program/Find.hs Outdated

Bodigrim reviewed

View reviewed changes

cabal-install/tests/UnitTests/Distribution/Client/ProjectConfig.hs Outdated

Bodigrim reviewed

View reviewed changes

Cabal-syntax/src/Distribution/Types/CondTree.hs Outdated

philderbeast force-pushed the hlint/use-fmap-operator branch from 1834ec6 to 91914a5 Compare

July 5, 2026 12:28

philderbeast force-pushed the hlint/use-fmap-operator branch 2 times, most recently from 580079b to 37f6728 Compare

July 23, 2026 19:38

Bodigrim reviewed

View reviewed changes

cabal-install/tests/UnitTests/Distribution/Client/ProjectConfig.hs Outdated

Bodigrim reviewed

View reviewed changes

Cabal-syntax/src/Distribution/SPDX/LicenseExpression.hs Outdated

Bodigrim reviewed

View reviewed changes

Cabal-syntax/src/Distribution/Types/VersionRange/Internal.hs Outdated

Cabal-syntax/src/Distribution/Types/AbiDependency.hs Outdated

Cabal-syntax/src/Distribution/Types/Module.hs Outdated

Cabal-syntax/src/Distribution/Utils/MD5.hs Outdated

Cabal-syntax/src/Distribution/System.hs Outdated

philderbeast force-pushed the hlint/use-fmap-operator branch 3 times, most recently from 712ac53 to 26b519a Compare

July 31, 2026 15:36

philderbeast mentioned this pull request

Use applicative parsing #12193

Merged

2 tasks

philderbeast commented Jul 31, 2026

Collaborator Author

@Bodigrim I've made all of your suggested changes to use applicative style for parsing but felt these changes went much further than satisfying HLint so have split these refactorings into #12193.

Bodigrim approved these changes

View reviewed changes

philderbeast force-pushed the hlint/use-fmap-operator branch from 8f7f107 to a3cc68a Compare

August 13, 2026 20:37

philderbeast and others added 27 commits

August 19, 2026 20:50


          Follow hlint suggestion: use <$>

d533d79


          Use <$>, avoiding explicit return

c7bae9d


          Rerun hlint --default

61d6b18


          Follow hlint suggestion by hand: use <$>

d7ce8bd


          Rerun hlint --default

463a351


          Follow hlint suggestion: redundant <$>

87d2d4e


          Follow hlint suggestion: redundant $

38046da


          Follow hlint suggestion: use <$>

e0ee5a6


          Follow hlint suggestion: redundant <$>

a7b3de6


          Follow hlint suggestion: redundant $

8091e25


          Follow hlint suggestion: redundant <$>

a658fa3


          Follow hlint suggestion: redundant bracket

2c3c2bd


          Follow hlint suggestion: use <$>

c8bef62


          Satisfy fourmolu

23cfed6


          Remove redundant brackets

60796cf


          Float liftIO outside filter

a4cc918


          Remove redundant brackets

081b045


          Use lookupEnv "PATH"

db72520


          Use lookupEnv "PATH" in test

11a389d


          Move maybe filterTargetsKind to RHS

a5249d0

Co-Authored-By: ˌbodʲɪˈɡrʲim <andrew.lelechenko@gmail.com>


          Add filterWholeComponentTargets

7ccaffb


          Use filterWholeComponentTargets again

d5a91ca


          Follow hlint suggestion: Move filter

71b65e5


          Remove redundant bracket

6203b0a


          Remove redundant bracket

93ab4bd


          Rerun hlint --default for counts

178a8a6


          Update counts with hlint --default

a14b8bc

philderbeast force-pushed the hlint/use-fmap-operator branch from a3cc68a to a14b8bc Compare

August 20, 2026 00:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attention: needs-review