Repository navigation
docs: polish README and standardise British English guides - #2
Conversation
|
Capy couldn't review this pull request because h1's workspace is out of credits, add credits or enable auto-reload to resume automatic reviews. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe README now provides a project overview and quick start. Dedicated guides cover reader behavior, development, deployment, and security. Repository guidance sets British English as the convention for maintained documentation. The environment example states that a private key is required before exposing the gateway. ChangesDocumentation and operating guidance
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The documented mock setup has no identified blocker. Merge after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The revised instructions strengthen guidance to use a private key before exposing the gateway. No new security flaw was verified. Dependency installation still runs third-party code, whose exact behaviour remains unverified. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nonnil
left a comment
There was a problem hiding this comment.
Reviewed the documentation changes against the current implementation and the latest main branch. No remaining actionable documentation regression found after resolving the issues below.
- Resolved the README conflict with main without rewriting branch history.
- Preserved main's native-scroll implementation and hardware-validation backlog verbatim. Updated the English README and reader guide to describe native scrolling, bounded UTF-16 chunks, creation followed by text upgrade, position indicators and the final media frame.
- Confirmed that the PR retains bearer-authenticated gateway guidance, loopback-only Safe Relay, user-configured pairing and the distinction between software checks and physical-device evidence.
- Fixed the CI-blocking High finding GHSA-2883-xcg3-v3hh by updating only the Even Hub CLI's transitive
js-yamldependency from 4.3.1 to 4.3.2 in the existing lockfile. No audit threshold or workflow was weakened. - A fresh
npm cifollowed bynpm run cipassed: the High-severity audit gate, formatting, repository invariants, TypeScript, 33 test files / 162 tests, all builds, production packaging and artefact checks. - GitHub CI run 36332912600 passed on the final reviewed commit. GitHub reports the PR as mergeable.
Residual risk: npm audit still reports three pre-existing Moderate entries involving Hono and Vitest/@vitest/mocker. They are outside this bounded documentation and CI-blocker fix; passing the configured High-severity gate is not a clean vulnerability report.
Verified package SHA-256: 1423b8d7f6450b84340a1cacff0a23aaded16a26e57a5a057e349cc1bbb900b9. The generated package remains untracked. No deployment or physical-device validation was performed.
This review is recorded as a comment because the authenticated account is also the PR author; it does not constitute an independent GitHub approval.
Summary
The README mixed Japanese and English and combined the product introduction with detailed operating instructions. Give it a concise, branded entry point with features, an authenticated mock quick start and a documentation table. Move the detailed content into reader, development, deployment and security guides.
Standardise maintained documentation on British English and update the documentation index and package instructions. Correct stale instructions against the current implementation: swipe down advances, the relay permits twelve operations, and the quick start now generates and supplies the gateway key. Clarify that public access requires bearer authentication in the configuration example.
Make the first-run path explicitly use the installed Even Hub simulator: the companion waits for its SDK bridge before enabling pairing, so a regular browser cannot complete setup. Include clone and runtime prerequisites, separate terminal steps, expected mock output and shutdown instructions. Set
X_SOURCE=mockexplicitly to avoid inheriting live mode from the shell.Preserve main's native reader scrolling when resolving the README conflict, including bounded UTF-16 chunks, text-container creation and upgrade, position indicators and the final media frame. Update only the transitive development dependency
js-yamlfrom 4.3.1 to 4.3.2 to clear the High-severity audit failure in CI; keep the audit threshold unchanged.Validation
npm ci && npm run cipassed: clean dependency installation, the High-severity audit gate, formatting, repository checks, TypeScript, 33 test files / 162 tests, all builds, production packaging and artefact checks.git diff --checkpassed.sh -n. The installed simulator's--helpconfirms the URL argument; runtime versions and expected output match the source.js-yamllockfile entry differ. Manifests and legal licence text are unchanged. No complete simulator pairing, deployment or hardware validation was performed.1423b8d7f6450b84340a1cacff0a23aaded16a26e57a5a057e349cc1bbb900b9(generated package untracked).Summary by CodeRabbit